Add VM schedules pages #1103

a110605 · 2024-08-14T09:52:32Z

Summary

add VM schedule list / edit / details pages
add VM schedule column in vmbackup / vmsnapshot list pages
add Create VM Scheduleaction for VM operation menu
show volume backup error message and readyToUse in backup/snapshot detail volume tab <- discussion conclusion with the team
upgrade cron-validator and cronstrue to the latest version

Note. this UI PR needs wait for backend PR harvester/harvester#6149 merge first.

PR Checklist

Is this a multi-tenancy feature/bug?
- Yes, the relevant RBAC changes are at:
Do we need to backport changes to the old Rancher UI, such as RKE1?
- Yes, the relevant PR is at:
Are backend engineers aware of UI changes?
- Yes, the backend owner is: @WebberHuang1118

Related Issue #
harvester/harvester#6058

Technical notes summary

run yarn install before run up the harvester dashboard

Screenshot/Video

Create VM Schedule

create_scheduling.mov

Edit VM Schedule

update_schedule.mov

See VM Schedule detail

schedule_detail.mov

show error banner if not set backup target

show_error_backup_target.mov

When create back up failed and reach Max Failure threshold, the schedule job would auto suspended.

Show volume backup error message and readyToUse in backup/snapshot detail volume tab

volume_backup_error.mov

a110605 · 2024-09-09T09:23:31Z

Let me rebase and test it again since backend PR has some minor change.

a110605 · 2024-09-19T04:52:08Z

Hi @WebberHuang1118 , @torchiaf , I've rebased this PR and ready to review.

pkg/rancher-components/package.json

torchiaf

I'm working on the review, before I look at the code, I found the following error, could you check ?

'Create Schedule' title starts with ':'
Cannot read properties of undefined (reading 'linkFor') when click create button.

a110605 · 2024-09-23T03:13:41Z

I'm working on the review, before I look at the code, I found the following error, could you check ?

'Create Schedule' title starts with ':'

Cannot read properties of undefined (reading 'linkFor') when click create button.

The backend PR is merged. Could you use master-head deployment and try again?

Should be looks like

mergify · 2024-09-24T02:26:18Z

This pull request is now in conflict. Could you fix it @a110605? 🙏

a110605 · 2024-09-24T02:57:53Z

This pull request is now in conflict. Could you fix it @a110605? 🙏

Done rebase.

WebberHuang1118 · 2024-09-24T06:55:18Z

LGTM, thans for the PR.

Just a point, if the schedule is suspended, the GUI doesn't show the condition?

For example, if the user suspends the schedule proactively, ScheduleVMBackup CR's status.conditions will have related message and reason.

a110605 · 2024-09-24T08:49:52Z

LGTM, thans for the PR.

Just a point, if the schedule is suspended, the GUI doesn't show the condition?

For example, if the user suspends the schedule proactively, ScheduleVMBackup CR's status.conditions will have related message and reason.

The stateDescription() is grabbing from this.state.conditions.message, will look like

bk201

The UX lgtm. However, I feel the word "VM Schedule" is confusing. Maybe "VM Backup Schedule" is more clear?
@jillian-maroket @asettle What do you think about this term.

a110605 · 2024-09-25T07:50:21Z

The UX lgtm. However, I feel the word "VM Schedule" is confusing. Maybe "VM Backup Schedule" is more clear? @jillian-maroket @asettle What do you think about this term.

But user can still create snapshot schedule job from this page, that why I give it Virtual Machine Schedule.

pkg/harvester/components/FilterVMSchedule.vue

pkg/harvester/detail/harvesterhci.io.schedulevmbackup/BackupList.vue

pkg/rancher-components/src/components/Form/LabeledInput/LabeledInput.vue

torchiaf

I left some comments and there are some small regressions:

When you click on 'Replace existing' / 'Restore New' from Virtual Machine Snapshots page or Virtual Machine Schedules -> Snapshots tab:
1. The UI is redirected to Backups create page rather than Snapshots create.
2. If you hit Cancel the UI is redirected to Backups page. The redirection should be to Virtual Machine Snapshots or Virtual Machine Schedules -> Snapshots tab, depending on navigation history.

Virtual Machine Snapshots

Screencast.from.2024-09-26.14-37-07.webm

Virtual Machine Schedules -> Snapshots tab

Screencast.from.2024-09-26.14-45-53.webm

Consider that some button actions are in common between Snapshots and Backup models.

torchiaf · 2024-09-26T10:57:04Z

pkg/rancher-components/package.json

@@ -32,8 +32,8 @@
    "@vue/test-utils": "1.2.1",
    "babel-eslint": "10.1.0",
    "core-js": "3.25.3",
-    "cron-validator": "1.2.0",


We should port this fix in rancher/dashboard.

pkg/harvester/dialog/HarvesterScheduleModal.vue

pkg/harvester/models/harvesterhci.io.virtualmachinebackup.js

- add VM schedule list/edit/details pages - add VM schedule column in vmbackup/vmsnapshot list pages - add action menu for VM - show volume backup error message in backup/snapshot detail volume tab Signed-off-by: andy.lee <andy.lee@suse.com>

Signed-off-by: andy.lee <andy.lee@suse.com>

a110605 · 2024-09-26T14:32:18Z

@WebberHuang1118 , could you help check why I can't restore new / restore existing snapshot or backup using schedule job generated backup / snapshot? It's fine to restore snapshot/backup which is manually created.

torchiaf

LGTM UI side.

torchiaf · 2024-09-26T15:11:17Z

@WebberHuang1118 , could you help check why I can't restore new / restore existing snapshot or backup using schedule job generated backup / snapshot? It's fine to restore snapshot/backup which is manually created.

IMHO the 500 error should be handled backend side, but the error message is consistent: If I stop the VM schedule from which the VM backups was created, I can manually restore the backup into a new VM.

WebberHuang1118 · 2024-09-27T01:10:18Z

@WebberHuang1118 , could you help check why I can't restore new / restore existing snapshot or backup using schedule job generated backup / snapshot? It's fine to restore snapshot/backup which is manually created.

Yes, the Harvester controller has the webhook to prevent restoring the snapshot/backup from a running schedule, since the backup/snapshots will be cleansed under the hood, leading to restore failure. By design, before restoring, the user should suspend the schedule first.

a110605 requested review from bk201, WebberHuang1118 and torchiaf August 14, 2024 09:52

a110605 self-assigned this Aug 14, 2024

a110605 force-pushed the issue-6058 branch 2 times, most recently from 6bc1799 to 2c50eb2 Compare August 14, 2024 10:13

a110605 marked this pull request as ready for review August 14, 2024 10:30

a110605 force-pushed the issue-6058 branch 2 times, most recently from 0846983 to a68a6cf Compare August 21, 2024 02:07

a110605 added the New Feature New feature for up coming release label Aug 26, 2024

a110605 force-pushed the issue-6058 branch from a68a6cf to 3d78d05 Compare September 19, 2024 04:10

torchiaf reviewed Sep 22, 2024

View reviewed changes

pkg/rancher-components/package.json Show resolved Hide resolved

torchiaf requested changes Sep 22, 2024

View reviewed changes

a110605 force-pushed the issue-6058 branch from 420f966 to dd3929d Compare September 23, 2024 13:29

a110605 force-pushed the issue-6058 branch from dd3929d to 6ab98fa Compare September 24, 2024 02:50

a110605 requested a review from torchiaf September 24, 2024 03:43

WebberHuang1118 approved these changes Sep 24, 2024

View reviewed changes

bk201 approved these changes Sep 25, 2024

View reviewed changes